-
-
Notifications
You must be signed in to change notification settings - Fork 93
Concept: Here Documents #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc is largely written in the passive voice. Was that an intentional choice?
That's the way Google Gemini spat it out at me, and I didn't do a rewrite. |
I wouldn't be so prescription. Maybe list it as a potential drawback vs "don't use them". "Here docs are great for X, Y, Z. However, they can sometimes break the flow of the code and make the code harder to read." |
A typical uses list could be nice. An example of "poor formatting" and "good formatting" options can be useful. |
Also replacing the image in the concept readme with a mermaid diagram.
cc50d52
to
3b19e82
Compare
@IsaacG if you can, please have a look at today's commits. |
@kotp are you sufficiently satisfied? Are there changes you'd like? |
Next concept: here documents and here strings.