Skip to content

modify concept exercise exercism-matrix #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025

Conversation

depial
Copy link
Contributor

@depial depial commented Aug 21, 2025

This modifies the concept exercise old-exercism-matrix to better align with about.md for the Concept multi-dimensional-arrays. Some notes:

  • The two matrix rotation tasks were removed.
  • Two new tasks were included: colpixelcount() and render().
  • These last two tasks are more general and move away from exclusively using the Exercism logo matrix.
  • Use of parts of most of the sections from introduction.md is possible/encouraged, with the exception of Generating evenly-spaced values.
  • Status is set to "wip".
  • The old UUID is being used.

During review, special attention should be given to instructions.md and hints.md to check for clarity. Testing should be sufficient, but any suggestions for added tests is welcomed.

@depial depial requested a review from colinleach August 21, 2025 23:24
@colinleach
Copy link
Contributor

Excellent news! I had no idea where to go with this, so I am (obviously!) delighted to see you rescue the situation.

First impressions positive, but I think it would be worth going through it in more detail tomorrow. It's not late in the day here, but my head feels like it far post-peak.

@depial
Copy link
Contributor Author

depial commented Aug 21, 2025

I think it would be worth going through it in more detail tomorrow.

Absolutely! Cast a critical eye on it tomorrow (or later) and also let me know if you think the two added tasks combine with the rest of the exercise plus the flow in general. Since this is a first iteration (which can tend to feel a bit forced), I wouldn't mind iterating again.

Copy link
Contributor

@colinleach colinleach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I haven't found anything to comment on.

@colinleach colinleach merged commit 7955cee into exercism:main Aug 22, 2025
5 checks passed
@colinleach
Copy link
Contributor

I got to it in the end, after a chaotic morning (emergency trip to the window blind store after one fell apart on me; neighbor panicking about a flat battery as she's trying to leave for a medical appointment, etc...)

@depial
Copy link
Contributor Author

depial commented Aug 22, 2025

Cheers! I'm glad it looks like everything is under control there :)

Looks like everything is working on the website.

I noticed that vector-operations is a leaf in the tree, but seems like it might be a prereq for this. What do you think?

@depial depial deleted the exercism-matrix branch August 22, 2025 20:41
@colinleach
Copy link
Contributor

I noticed that vector-operations is a leaf in the tree

It shouldn't be! I just confirmed in the config.json that the dependencies go vector-operations -> functions -> function-composition -> multi-dimensional-arrays.

For display on the website, I think Jeremy wrote Ruby code to unclutter the tree, hiding some of the more distant prereqs. It still enforces them, though.

@depial
Copy link
Contributor Author

depial commented Aug 23, 2025

Good to know! I was thinking it was starting to look a bit cluttered already... Imagine without that Ruby code :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants