-
Notifications
You must be signed in to change notification settings - Fork 154
Reimplement ReviewMappingsController #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nih326
wants to merge
30
commits into
expertiza:main
Choose a base branch
from
nih326:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
management improvements Core Changes: - Add MAX_OUTSTANDING_REVIEWS constant to Assignment model - Add team name functionality to Team model - Fix nil comparison in can_review? method - Add self-review functionality to review mappings - Add questionnaire ID retrieval for reviews API Changes: - Add new review mapping endpoints: - POST /start_self_review - GET /get_questionnaire_id - Update review mapping controller with new actions - Add error handling for review creation Model Updates: - Update Assignment model with review constants - Add name method to Team model - Update ReviewMapping model with self-review logic - Add questionnaire association methods Documentation: - Update API documentation in swagger.yaml - Add comments for new methods and endpoints This commit improves the review system by adding self-review capabilities, fixing review validation issues, and enhancing team identification.
implementing assigned functionality for review_mapping
…iewers for an assignmet
Feature csalitre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.