-
Notifications
You must be signed in to change notification settings - Fork 155
E2524. Reimplement student_review_controller.rb #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kii4ka
wants to merge
46
commits into
expertiza:main
Choose a base branch
from
Kii4ka:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created StudentReviewService and removed MetareviewResponseMap from controller
simplify ( action_allowed? )
…overage reporting
…overage reporting
…overage reporting
wait for the MySQL service to be fully ready before proceeding with database setup add: - name: Wait for MySQL to be ready run: | while ! nc -z localhost 3306; do echo "Waiting for MySQL..." sleep 3 done echo "MySQL is ready."
…tation-back-end into Katerina_tests
Katerina tests
Updated workflow
To test actions
Danger has errored[!] Invalid
Generated by 🚫 Danger |
🚨 RSpec Tests Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across multiple areas, including infrastructure setup, CI/CD improvements, controller and service additions, and configuration updates. Below is a summary of the most significant changes, grouped by theme:
Infrastructure and Configuration Updates:
.dockerignore
file to exclude unnecessary files and directories from Docker builds, improving efficiency.config/database.yml
,config/database.yml.backup
, andconfig/database.yml.local
to include database credentials (username
,password
, andhost
) and removed thesocket
configuration. [1] [2] [3]config/application.rb
to conditionally set the cache store to either Redis or memory, based on the presence of theCACHE_STORE
environment variable.CI/CD Workflow Enhancements:
.github/workflows/main.yml
to include a MySQL readiness check before running database setup, ensuring the database is fully operational.CC_TEST_REPORTER_ID
secret before uploading coverage reports. [1] [2]New Controller and Service for Reviews:
Api::V1::StudentReviewController
to handle student review-related actions, including authorization, service initialization, and error handling.StudentReviewService
to encapsulate the business logic for managing student reviews, such as loading participant data, calculating review progress, and handling bidding redirection.Localization and Authorization Improvements:
set_locale
method inApplicationController
to dynamically set the locale based on request parameters or theAccept-Language
header.student_review/list
inconfig/routes.rb
to support the newly added controller action.Miscellaneous Updates:
docker-compose.yml
to change the MySQL user toroot
, aligning with the database configuration changes.Gemfile
to makesimplecov_json_formatter
optional by settingrequire: false
.