Skip to content

Refactored Teams Hierarchy #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Refactored Teams Hierarchy #212

wants to merge 11 commits into from

Conversation

@Chinzzii
Copy link
Collaborator

@Chinzzii Chinzzii commented Oct 1, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

4 Warnings
⚠️ Pull request is too big (more than 500 LoC).
⚠️ Pull request has duplicated commit messages.
⚠️ Pull request modifies config or setup files: config/database.yml.
⚠️ RSpec tests seem shallow (single it blocks or no context). Consider improving test structure.

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

🚨 RSpec Tests Report

All tests passed.

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

🚨 RSpec Tests Report

All tests passed.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

🚨 RSpec Tests Report

All tests passed.

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

🚨 RSpec Tests Report

All tests passed.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/mentored_team_spec.rb:27 # MentoredTeam validations is valid on :create without a mentor
rspec ./spec/models/mentored_team_spec.rb:72 # MentoredTeam#assign_mentor returns an error if no mentor duty exists on the assignment
rspec ./spec/models/mentored_team_spec.rb:115 # MentoredTeam#add_member adds a regular participant successfully
rspec ./spec/models/mentored_team_spec.rb:132 # MentoredTeam#full? does not count the mentor toward team capacity
rspec ./spec/models/mentored_team_spec.rb:151 # MentoredTeam#full? is full when regular members reach max_team_size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Chinzzii @prithishsamanta