Fix 405 error when connecting to servers requiring Accept header #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connecting to MCP servers via streamable HTTP, mcptools was not setting the Accept header. Some servers like mcp.grep.app require clients to accept both application/json and text/event-stream, and return 405 errors when this header is missing. This change ensures the Accept header is always set for both HTTP and SSE transports, fixing compatibility with servers that enforce this requirement. Tested with mcp.grep.app and existing unit tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When attempting to connect to certain MCP servers like mcp.grep.app using streamable HTTP transport, mcptools returns a 405 error:
This happens because some MCP servers require the client to include an Accept header that specifies support for both application/json and text/event-stream. Without this header, the server rejects the request.
Solution
This PR modifies the HTTP and SSE transport setup to always include the required Accept header. The change is minimal and affects the header initialization in
cmd/mcptools/commands/utils.go.The fix also simplifies the existing logic by removing conditional header passing, since we now always have at least the Accept header to send.
Testing
Verified the fix works with mcp.grep.app:
$ ./mcp tools https://mcp.grep.app searchGitHub(query:str, [language:str[]], [matchCase:bool], ...) Find real-world code examples from over a million public GitHub repositories...All existing unit tests continue to pass.