add hello world js example #30
Conversation
|
This feels very similar to the other sample. I would be fine with replacing it with this one. Additionally, users aren't being directed to this sample if that is the goal. You haven't tested this in CI and didn't add actual tests to Vitest, so what is the purpose here? |
| "devDependencies": { | ||
| "vite": "^6.2.0", | ||
| "vite-plugin-fable": "file:..", | ||
| "vite-plugin-fable": "./lib/latest.tgz", |
There was a problem hiding this comment.
tgz seems weird, can't you use ../?
There was a problem hiding this comment.
i tried but i had issues with recursion as it seems to install the whole univers in node_modules/vite-plugin-fable/...../node_modules/vite-plugin-fable.... and adding a bunch fo files even though they are not mentioned in files in root package.json, so i found this solution to be a bit better/slimmer and not having that recursive issue
There was a problem hiding this comment.
I see, yeah that is probably why I went with import plugin from "../index.js" instead.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Fable.Browser.Dom" Version="2.14.0" /> | ||
| <PackageReference Include="Fable.Core" Version="4.3.0" /> |
There was a problem hiding this comment.
this is a regular fable / vite counter app with vanillajs
2 participants
add a hello world vanilla js program referencing the library as npm dependency directly
file: ..(points to root package.json) as it creates circular depscan be run as
bun iandbun run devsimilar to sample-project