Skip to content

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Aug 29, 2024

Fixes #6313

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Copy link

Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make it explicit in the javadoc that this might give an unexpected result, thus the plural form is not necessarily same as the plural form on the server.

@metacosm
Copy link
Collaborator Author

metacosm commented Mar 6, 2025

I would make it explicit in the javadoc that this might give an unexpected result, thus the plural form is not necessarily same as the plural form on the server.

Added a comment to that effect.

Copy link

sonarqubecloud bot commented Mar 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose method that computes the default plural form for a given kind

2 participants