IceCube: Config Update and Fixup AgentCoppEapolTest/*EapolToHighPriQ #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AgentCoppEapolTest/*EapolToHighPriQ failed with following error:
V0415 04:32:06.142405 240788 AgentCoppTests.cpp:387] Packet of dstMac=ff:ff:ff:ff:ff:ff. Ethertype=888e. Queue=9, before pkts:0, after pkts:0
/var/FBOSS/th6_0905/fboss/agent/test/agent_hw_tests/AgentCoppTests.cpp:393: Failure
Expected equality of these values:
1
afterOutPkts - beforeOutPkts
Which is: 0
Motivation
fixup testcase AgentCoppEapolTest/*EapolToHighPriQ of sai_agent_hw_test
RootCause:
the Eapol packet constructed by Fboss was a broadcast packet, while ASIC TOMAHAWK6 won't punt the broadcast Eapol packet to the right queue without sai_eapol_trap_use_bcast_mac enabled
Fix:
Test Plan
rerun sai_agent_hw_test with gtest_filter "AgentCoppEapolTest/0.EapolToHighPriQ"
./sai_agent_hw_test-sai_impl --gtest_filter=AgentCoppEapolTest/0.EapolToHighPriQ
EapolToHighPriQ.txt