Skip to content

Conversation

@sarahfu331
Copy link
Contributor

@sarahfu331 sarahfu331 commented Sep 12, 2025

Description

AgentCoppEapolTest/*EapolToHighPriQ failed with following error:

V0415 04:32:06.142405 240788 AgentCoppTests.cpp:387] Packet of dstMac=ff:ff:ff:ff:ff:ff. Ethertype=888e. Queue=9, before pkts:0, after pkts:0
/var/FBOSS/th6_0905/fboss/agent/test/agent_hw_tests/AgentCoppTests.cpp:393: Failure
Expected equality of these values:
1
afterOutPkts - beforeOutPkts
Which is: 0

Motivation

fixup testcase AgentCoppEapolTest/*EapolToHighPriQ of sai_agent_hw_test
RootCause:
the Eapol packet constructed by Fboss was a broadcast packet, while ASIC TOMAHAWK6 won't punt the broadcast Eapol packet to the right queue without sai_eapol_trap_use_bcast_mac enabled
Fix:

  1. Update fboss/oss/link_test_configs/vendor/icecube800bc.materialized_JSON to the latest sai test config file provided by Meta
  2. Based on the upper file, add "sai_eapol_trap_use_bcast_mac :1" to platform->chip->asicConfig->common->yamlConfig part to fixup testcase AgentCoppEapolTest/*EapolToHighPriQ

Test Plan

rerun sai_agent_hw_test with gtest_filter "AgentCoppEapolTest/0.EapolToHighPriQ"
./sai_agent_hw_test-sai_impl --gtest_filter=AgentCoppEapolTest/0.EapolToHighPriQ
EapolToHighPriQ.txt

@meta-cla meta-cla bot added the CLA Signed label Sep 12, 2025
@daiwei1983
Copy link
Contributor

daiwei1983 commented Sep 18, 2025

"sai_eapol_trap_use_bcast_mac :1" change looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants