-
Notifications
You must be signed in to change notification settings - Fork 357
Icetea: config: setting TMP432 register value for HW OTP function #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "kernelDeviceName": "tmp432", | ||
| "pmUnitScopedName": "SMB_TH6_SENSOR_TMP432_1" | ||
| "pmUnitScopedName": "SMB_TH6_SENSOR_TMP432_1", | ||
| "initRegSettings": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a __comment__ key in the json with value describing the reasoning for this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a
__comment__key in the json with value describing the reasoning for this change
@somasun Thanks for the comments, will do soon.
| "kernelDeviceName": "tmp432", | ||
| "pmUnitScopedName": "SMB_TH6_SENSOR_TMP432_2" | ||
| "pmUnitScopedName": "SMB_TH6_SENSOR_TMP432_2", | ||
| "initRegSettings": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
|
@binhuang00 has imported this pull request. If you are a Meta employee, you can view this in D83879933. |
|
@joywu-coder thanks! What files should we read to get an accurate reading of the TH6 sensor which the HW OTP function is relying on? |
|
@binhuang00 merged this pull request in b05e9c9. |
@somasun, please refer to the design document: https://docs.google.com/document/d/1P0D9GkvIzYzzxyELcJtdt27-4ze8uGUluo3H9DXJH9M/edit?tab=t.0 |
Description
Update platform_manager.json file:
Please refer to the description of the tmp432 datasheet:
Motivation
Test Plan
Step 1: Check the original TMP432 sensor value and register value.

Step 2: Run platform_manager. Note: if the tmp432 driver has ever been loaded before, then the "--reload-kmods" is required when running platform_manager for the first time.
Step 3: Check the TMP432 sensor value and register value again.
Please refer to the detailed logs: TMP432_setting_log.txt
Please refer to the new logs for the comments update: platform_manager_930.log