Skip to content

Conversation

@joywu-coder
Copy link
Contributor

@joywu-coder joywu-coder commented Sep 29, 2025

Description

Update platform_manager.json file:

  1. Set the TMP432 register addresses 0x27 and 0x28 to a value of 0x05.
  2. Set the high threshold for the TMP432 remote temperature to 105 degrees. Since TMP432_2 (Remote Temperature 2) is not utilized in the hardware, ensure that TMP432_1 (Remote Temperature 1, Remote Temperature 2) and TMP432_2 (Remote Temperature 1) are correctly set.

Please refer to the description of the tmp432 datasheet:

image image image

Motivation

  1. According to the hardware team's test result, the 0x27 & 0x28 register values ​​need to be set to 0x05 to calibrate the TMP432 temperature values.
  2. According to HW OTP(over temperature protection) requirements, the TMP432 remote temperature high threshold should be set to 105°C after the OS boots.
image

Test Plan

Step 1: Check the original TMP432 sensor value and register value.
Step 2: Run platform_manager. Note: if the tmp432 driver has ever been loaded before, then the "--reload-kmods" is required when running platform_manager for the first time.
Step 3: Check the TMP432 sensor value and register value again.
image
Please refer to the detailed logs: TMP432_setting_log.txt
Please refer to the new logs for the comments update: platform_manager_930.log

@meta-cla meta-cla bot added the CLA Signed label Sep 29, 2025
"kernelDeviceName": "tmp432",
"pmUnitScopedName": "SMB_TH6_SENSOR_TMP432_1"
"pmUnitScopedName": "SMB_TH6_SENSOR_TMP432_1",
"initRegSettings": [
Copy link
Contributor

@somasun somasun Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a __comment__ key in the json with value describing the reasoning for this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a __comment__ key in the json with value describing the reasoning for this change

@somasun Thanks for the comments, will do soon.

"kernelDeviceName": "tmp432",
"pmUnitScopedName": "SMB_TH6_SENSOR_TMP432_2"
"pmUnitScopedName": "SMB_TH6_SENSOR_TMP432_2",
"initRegSettings": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@joywu-coder joywu-coder requested a review from somasun September 30, 2025 06:04
@meta-codesync
Copy link

meta-codesync bot commented Oct 3, 2025

@binhuang00 has imported this pull request. If you are a Meta employee, you can view this in D83879933.

@somasun
Copy link
Contributor

somasun commented Oct 6, 2025

@joywu-coder thanks!

What files should we read to get an accurate reading of the TH6 sensor which the HW OTP function is relying on?

@meta-codesync
Copy link

meta-codesync bot commented Oct 7, 2025

@binhuang00 merged this pull request in b05e9c9.

@joywu-coder
Copy link
Contributor Author

@joywu-coder thanks!

What files should we read to get an accurate reading of the TH6 sensor which the HW OTP function is relying on?

@somasun, please refer to the design document: https://docs.google.com/document/d/1P0D9GkvIzYzzxyELcJtdt27-4ze8uGUluo3H9DXJH9M/edit?tab=t.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants