[test] Import changes to port sharedmem tables into OCaml 5.2 domain-based parallelism #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and also fix some script shebangs
Since some of these tests are parallel themselves, I don't want to put to much load on the system, which might (?) artificially degrade the measurements.
|
@grievejia has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folks at Tarides have already experimented with porting Pyre's multi-processing sharedmem library into relying on OCaml5's domain-based multi-threading mechanism.
I'm creating this PR so we have an easy way of importing the changes into Meta's internal repository. Please do not accept this change -- it's likely to require some cleanup work. But we should start experimenting & benchmarking with it and see how much perf gain we could reap (and hopefully report the numbers back to the original author).