Filter project excludes for site package path entries if they would exclude search path #1533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xclude search path Summary: Pyrefly has some logic to add all `site-package-path` entries to `project-excludes`, but sometimes the Python interpreter includes the root of the project. Historically, we've filtered this out by using the project root, but if the actual project root differs from what Pyrefly thinks it is, we might end up excluding the project by default. This happens in legacy projects, where instead of using `src` as the project directory, `lib` is used. This diff instead uses all `search-path` entries, not just Pyrefly's heuristic project root, to determine if a site package path should be added. This way, anything that might be considered "project code" because it's in `search-path` will always be able to be included in `project-includes`. Fixes facebook#1498 Reviewed By: kinto0 Differential Revision: D86682740
|
@connernilsen has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86682740. |
kinto0
approved these changes
Nov 10, 2025
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pyrefly has some logic to add all
site-package-pathentries toproject-excludes, but sometimes the Python interpreter includes the root of the project. Historically, we've filtered this out by using the project root, but if the actual project root differs from what Pyrefly thinks it is, we might end up excluding the project by default.This happens in legacy projects, where instead of using
srcas the project directory,libis used.This diff instead uses all
search-pathentries, not just Pyrefly's heuristic project root, to determine if a site package path should be added. This way, anything that might be considered "project code" because it's insearch-pathwill always be able to be included inproject-includes.Fixes #1498
Reviewed By: kinto0
Differential Revision: D86682740