make NativeAnimatedNodesManagerProvider owner of animationBackend #54079
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
zeyap
force-pushed
the
export-D83870762
branch
from
4cf5ce7 to
6faa4ec
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…cebook#54079) Summary: ## Changelog: [Internal] [Changed] - make NativeAnimatedNodesManagerProvider owner of animationBackend so NativeAnimatedNodesManager and NativeAnimatedNodesManagerProvider don't both keep a shared_ptr reference Reviewed By: sammy-SC Differential Revision: D83870762
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…cebook#54079) Summary: ## Changelog: [Internal] [Changed] - make NativeAnimatedNodesManagerProvider owner of animationBackend so NativeAnimatedNodesManager and NativeAnimatedNodesManagerProvider don't both keep a shared_ptr reference Reviewed By: sammy-SC Differential Revision: D83870762
zeyap
force-pushed
the
export-D83870762
branch
from
6faa4ec to
ba7a803
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…cebook#54079) Summary: ## Changelog: [Internal] [Changed] - make NativeAnimatedNodesManagerProvider owner of animationBackend so NativeAnimatedNodesManager and NativeAnimatedNodesManagerProvider don't both keep a shared_ptr reference Reviewed By: sammy-SC Differential Revision: D83870762
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…cebook#54079) Summary: ## Changelog: [Internal] [Changed] - make NativeAnimatedNodesManagerProvider owner of animationBackend so NativeAnimatedNodesManager and NativeAnimatedNodesManagerProvider don't both keep a shared_ptr reference Reviewed By: sammy-SC Differential Revision: D83870762
zeyap
force-pushed
the
export-D83870762
branch
from
ba7a803 to
0efd303
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…cebook#54079) Summary: ## Changelog: [Internal] [Changed] - make NativeAnimatedNodesManagerProvider owner of animationBackend so NativeAnimatedNodesManager and NativeAnimatedNodesManagerProvider don't both keep a shared_ptr reference Reviewed By: sammy-SC Differential Revision: D83870762
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…cebook#54079) Summary: ## Changelog: [Internal] [Changed] - make NativeAnimatedNodesManagerProvider owner of animationBackend so NativeAnimatedNodesManager and NativeAnimatedNodesManagerProvider don't both keep a shared_ptr reference Reviewed By: sammy-SC Differential Revision: D83870762
zeyap
force-pushed
the
export-D83870762
branch
from
0efd303 to
671acd7
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 9, 2025
…cebook#54079) Summary: ## Changelog: [Internal] [Changed] - make NativeAnimatedNodesManagerProvider owner of animationBackend so NativeAnimatedNodesManager and NativeAnimatedNodesManagerProvider don't both keep a shared_ptr reference Reviewed By: sammy-SC Differential Revision: D83870762
…nd dep (facebook#54091) Summary: ## Changelog: [Internal] [Changed] - use processor flag -DRN_USE_ANIMATION_BACKEND to gate animation backend dep So it's only enabled for catalyst and fantom when building with BUCK while gated from other meta apps, and enabled by default in oss version Reviewed By: sammy-SC Differential Revision: D84157729
…cebook#54079) Summary: ## Changelog: [Internal] [Changed] - make NativeAnimatedNodesManagerProvider owner of animationBackend so NativeAnimatedNodesManager and NativeAnimatedNodesManagerProvider don't both keep a shared_ptr reference Reviewed By: sammy-SC Differential Revision: D83870762
zeyap
force-pushed
the
export-D83870762
branch
from
671acd7 to
773fae5
Compare
|
This pull request has been merged in 53464e8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Changed] - make NativeAnimatedNodesManagerProvider owner of animationBackend
so NativeAnimatedNodesManager and NativeAnimatedNodesManagerProvider don't both keep a shared_ptr reference
Reviewed By: sammy-SC
Differential Revision: D83870762