Deprecate NetworkingModule.sendRequestInternal #54101
Closed
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Summary: Changelog: [Android][Deprecated] Mark `NetworkingModule.sendRequestInternal` as deprecated The `NetworkingModule.sendRequestInternal` method is an implementation detail of the `sendRequest` method and does not need to be public. In this diff, we mark it as deprecated ahead of removing it from the public API in a future release of React Native. Differential Revision: D84250142
motiz88
force-pushed
the
export-D84250142
branch
from
21e7e35 to
512695d
Compare
|
This pull request was successfully merged by @motiz88 in 30999b8 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 30999b8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Android][Deprecated] Mark
NetworkingModule.sendRequestInternalas deprecatedThe
NetworkingModule.sendRequestInternalmethod is an implementation detail of thesendRequestmethod and does not need to be public. In this diff, we mark it as deprecated ahead of removing it from the public API in a future release of React Native.Differential Revision: D84250142