-
Notifications
You must be signed in to change notification settings - Fork 53
Advance velox #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kevinwilfong
wants to merge
1
commit into
facebookincubator:main
Choose a base branch
from
kevinwilfong:advance_velox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Advance velox #202
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| include_guard(GLOBAL) | ||
|
|
||
| # TODO: these variables are named VELOX_* because we are piggy-backing on | ||
| # Velox's resolve dependency module for now. We should change and have our own | ||
| # in the future. | ||
| set(VELOX_ABSL_VERSION 20240116.0) | ||
| set(VELOX_ABSL_BUILD_SHA256_CHECKSUM | ||
| "338420448b140f0dfd1a1ea3c3ce71b3bc172071f24f4d9a57d59b45037da440") | ||
| set(VELOX_ABSL_SOURCE_URL | ||
| "https://github.com/abseil/abseil-cpp/archive/refs/tags/${VELOX_ABSL_VERSION}.tar.gz" | ||
| ) | ||
|
|
||
| velox_resolve_dependency_url(ABSL) | ||
|
|
||
| message(STATUS "Building Abseil from source") | ||
|
|
||
| FetchContent_Declare( | ||
| absl | ||
| URL ${VELOX_ABSL_SOURCE_URL} | ||
| URL_HASH ${VELOX_ABSL_BUILD_SHA256_CHECKSUM}) | ||
|
|
||
| set(ABSL_BUILD_TESTING OFF) | ||
| set(ABSL_PROPAGATE_CXX_STD ON) | ||
| set(ABSL_ENABLE_INSTALL ON) | ||
| FetchContent_MakeAvailable(absl) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule velox
updated
2033 files
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that
libgeos++-devin Ubuntu 22.04 is broken./usr/lib/x86_64-linux-gnu/cmake/GEOS/geos-targets.cmakehas-DGEOS_INLINEbutlibgeos++-devdoesn't includegeos/geom/Coordinate.inl. Can we use bundled GEOS instead of system GEOS in our CI?https://github.com/facebookincubator/nimble/actions/runs/16129216181/job/45513155656?pr=202#step:5:2248
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can revert this change because facebookincubator/velox#14103 has been merged.
Now, we can build Velox with
set(VELOX_ENABLE_GEO OFF).