Skip to content

Conversation

Ipstenu
Copy link
Contributor

@Ipstenu Ipstenu commented Sep 1, 2025

Added https://github.com/fairpm/mini-fair-repo to VCS

I'm not sure if I need to add it to the requirements?

Signed-off-by: Mika Ipstenu Epstein <[email protected]>
@rmccue
Copy link
Member

rmccue commented Sep 2, 2025

I'm not sure if I need to add it to the requirements?

You will, yeah; recommend using composer require for this as the composer.lock needs to be updated to match too.

@Ipstenu
Copy link
Contributor Author

Ipstenu commented Sep 2, 2025

@rmccue As soon as I do that, it also installs the theme. Is that okay for this PR?

@rmccue
Copy link
Member

rmccue commented Sep 8, 2025

(Per call today, for posterity:)

@Ipstenu Yeah, that's fine; the theme update is from a missed composer update which dependabot should have been picking up, likewise the AWS SDK update.

fwiw, if you want to avoid this locally, composer update your/package will update the lock file with just the package you're changing, and -W flag will add its dependencies as well (but nothing else).

Signed-off-by: Mika Ipstenu Epstein <[email protected]>
@Ipstenu
Copy link
Contributor Author

Ipstenu commented Sep 8, 2025

@rmccue That's why its weird.

composer update -W fairpm/mini-fair-repo extracted the theme archive!

@rmccue
Copy link
Member

rmccue commented Sep 8, 2025

Ohhh, it extracted it? I see what you mean now - that should be in .gitignore (cc @joedolson), looks like that was missed.

Could you add it to gitignore instead then please? :)

@Ipstenu
Copy link
Contributor Author

Ipstenu commented Sep 8, 2025

AhhH! Okay will do

Signed-off-by: Mika Ipstenu Epstein <[email protected]>
@Ipstenu
Copy link
Contributor Author

Ipstenu commented Sep 8, 2025

@rmccue That looks a lot better. Three file changes :D

Ipstenu and others added 3 commits September 18, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants