Add VTK file that takes a folder path and outputs more fields by default #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Djneu, Thanks for the PR and sorry for the wait. Probably a cleaner way to do this would have been to refactor the current VTK routine to make it a bit more flexible, but this would be more work with breaking changes. TBH I'm a bit reluctant adding more functionality since this repository is in maintenance-only mode (#55 (comment)), but if that's something helpful for you I'd be fine doing an exception here. |
|
Hi @benbovy, no problem and thanks for the reply! In this case I think we will keep a separate branch of this fortran version for the small changes we will make as the eventual plan is to convert the plugin to work with the C++ version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This is a modified VTK file we've been using with the fastscape-aspect coupling which takes a folder path (assuming a separate program has already created this and the VTK folder), and creates VTK files into this that by default show the topography, basement, erosion rate, total erosion, drainage area, and catchment.
Would it be possible to include this file on the main branch? Thank you for your time!