Just use translated language name and country code for language name from iso639 and iso3166 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from iso639 and iso3166 QLocale, or icu locale, no matter which, has only iso639-2 support. We may use code from iso639-3 or even more. Also, the native language, since we only use them for terriority, which means in real only zh_CN & zh_TW will be using such function. It doesn't really serve the purpose of always show language name in native language. In the end, the change is: 1. use iso639 to get langauge name, in English & Translated 2. Display with translated, but search with both English / Translated. Fix #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QLocale, or icu locale, no matter which, has only iso639-2 support. We
may use code from iso639-3 or even more.
Also, the native language, since we only use them for terriority, which
means in real only zh_CN & zh_TW will be using such function. It doesn't
really serve the purpose of always show language name in native
language.
In the end, the change is:
Fix #92