Skip to content

Conversation

@lo48576
Copy link
Contributor

@lo48576 lo48576 commented Apr 12, 2025

In some cases, input panel does not disappear even when it should.
To reproduce:

  1. Switch to Hiragana mode
  2. Put something to preedit.
    • For example, type k y to put ky to preedit.
  3. Switch to another mode.
    • For example, type l (set-input-mode-latin command in hiragana mode) to switch to Latin mode.
  4. Now you see the floating window (with ky for example) even though the current input mode is Latin.
    • Even worse, this does not disappear until you fill preedit with another content or change the window focus.

The patch solves this issue by updating input panel (floating window) when the input mode is changed and the preedit is cleared.

@wengxt wengxt merged commit 3a7c69b into fcitx:master Apr 30, 2025
3 checks passed
@lo48576 lo48576 deleted the fix/libskk-preedit-on-mode-change branch May 2, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants