Added new BulkOnly public functions: SCSITransaction12() and SCSITransaction16() #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original warning message was: large integer implicitly truncated to unsigned type [-Woverflow]
Collaborator
|
Sorry for not getting back to you. I can't really merge it as is because you changed the INT pin. |
Author
|
Hi,
I cannot remember why I did this, but there was probably a good reason :)
Let me look into it and resubmit.
--
Adam McDaniel
…On Tue, Jan 12, 2021 at 1:12 PM Kristian Sloth Lauszus < ***@***.***> wrote:
Sorry for not getting back to you. I can really merge it as is because you
changed the INT pin.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#528 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB2ABYVGR3PFIKUQAYQXE3SZSUJFANCNFSM4MQ4G3VQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for compatibility with devices requiring 12-byte and 16-byte CDB transactions, and for support for 32-bit and 64-bit LBAs.