New implementation for sifting #21
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for exploring the possibility of shifting towards the code structure of cg.jl in IterativeSolvers.jl. Compared with the current implementation, it shares the same ideas but in my view easier to follow and maintain:
SiftIterable
for storing sifting variables, instead of oneSiftIterable
and oneSiftState
. All the input variables and intermediate variables are kept in the same place, which may make it easier to add other extensions.iterate
method forSiftIterable
, and anothersift_iterator
method for initializingSiftIterable
. I think this is easier to understand than two dispatchediterate
methods.Besides, I changed some parts of the variable names, e.g.
maxes
-->maxs
,yvec
-->y
, but we can always make better names later.Take a look and we can discuss more about this!