chore(java): Add test-definition to reproduce error on nullable named request types #9272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstanmay13
approved these changes
Sep 13, 2025
|
Can close this as this was fixed in the PR FER-6479: [Intercom, java] Incorrect handling when a request body schema is a named type with nullable: true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I recently found an edge case where the java generator can end up generating code where .isPresent() is called on a type that isn't wrapped in an Optional<>.
Adding a test fixture to demonstrate, and marking them as allowed to fail in java-sdk/seed.yml
Testing