feat(go): setters, support for explicit null #9487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickthornton
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
patrickthornton
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
patrickthornton
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
| @@ -0,0 +1,116 @@ | |||
| package internal | |||
There was a problem hiding this comment.
I will mention that AsIs files are fixed in the v2 generator as of #9314 but on second thought I think its fine to keep it here for now and we can migrate all of the AsIs files in one go at a future time. Carry on
| }(), | ||
| wantBytes: []byte(`{"enabled":false}`), | ||
| }, | ||
| { |
There was a problem hiding this comment.
Can you add a test case here for deeply-nested types perhaps?
patrickthornton
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
patrickthornton
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
patrickthornton
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
patrickthornton
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
patrickthornton
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
patrickthornton
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear ticket: Fixes FER-3852, Fixes FER-6561
Adds setter methods for every object. These setters also mark a bitfield that keeps track of which fields have been set; just before serialization, these fields are made non-optional (i.e.
omitemptyis removed) which allows users to pass explicit null even when the argument is originally marked optional.Changes Made
Changes to the
v1side of the generator; addition of two as-is files,explicit_fields.goandexplicit_fields_test.go, that handle preprocessing of structs to un-optionalize any optional arguments that have been explicitly set to some value.Testing
Tested against Auth0's API and against all fixtures (hence this PR being completely massive; it adds about 400 lines of as-is Go to every fixture, for starters).