fix: properly handle onboard and delaying between retries #20
+113
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if onboardingPerformed { | ||
| break | ||
| } | ||
| // TODO: if this is the last instruction, set rvEntryDelay to whatever is the last delay, and use it below outside the main for loop |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
pending clarification from spec @ben-krieger |
Clarifications will be made to the FDO 2.0 spec. For now, decide on the most logical behavior and this will provide guidance for the spec authors. |
Signed-off-by: Antonio Murdaca <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
proper-onboard-loop-delay
branch
from
7cc0a75 to
1e78775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I interpret https://fidoalliance.org/specs/FDO/FIDO-Device-Onboard-PS-v1.1-20220419/FIDO-Device-Onboard-PS-v1.1-20220419.html#RVInfo is that we should be waiting in a loop and "sleep" if: a) we have a delay in the instruction set before trying the next and b) at the end of the instructions, we'll retry everything but we'll wait for "delay" from the last instruction
@ben-krieger ptal (this is how we mostly done this part in rust as well, just an infinite loop and retries)