Code Quality: Refactor launcher update logic and remove hash check #17890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed SHA256 hash file and related hash comparison logic from Files.App.Launcher update process. Now uses a branch file (Branch.txt) to determine if the launcher should be updated, simplifying the update mechanism. Updated PowerShell command to ensure Branch.txt is created during setup. This streamlines the update process and improves maintainability.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed SHA256 hash file and related hash comparison logic from Files.App.Launcher update process. Now uses a branch file (Branch.txt) to determine if the launcher should be updated, simplifying the update mechanism. Updated PowerShell command to ensure Branch.txt is created during setup. This streamlines the update process and improves maintainability.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
This PR is a little challenging to test without deploying a preview build.