Skip to content

Conversation

@unixfox
Copy link

@unixfox unixfox commented Nov 24, 2024

Hello,

I'm running BotD in production and with one of my user I diagnosed that navigator.plugins.length returns 0 on his browser.

He is running Vivaldi 7.0.3495.18 (Stable channel) on Windows and without any extension installed the browser gives no plugins in the list:

image

I'm proposing to remove the classification that if the plugins list is empty, then it's a headless chrome.

First because now for --headless=new, the value for navigator.plugins.length is not empty anymore. It's 5. Everyone is already using that new headless method or spoofing the value for navigator.plugins

And second, the API navigator.plugins is no longer recommended: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/plugins. So we may run into some false positive if some browser decides to not disclose the plugins list as part of protecting the privacy of the user.

@xnerhu xnerhu requested a review from bayotop November 25, 2024 09:09
@xnerhu xnerhu requested review from r-valitov and xnerhu November 25, 2024 09:09
@unixfox
Copy link
Author

unixfox commented Jan 14, 2025

hello @xnerhu @r-valitov any update on this PR :)? I have been using on my own website and I haven't had any user complain anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants