Skip to content

Conversation

sth0
Copy link
Contributor

@sth0 sth0 commented Feb 21, 2025

pre-commit-py 4.1.0 new package only for python 3.9+ needed for black which is also only 3.9+

@sth0 sth0 added the new package Packages that do not yet exist in Fink. label Feb 21, 2025
@sth0 sth0 self-assigned this Feb 21, 2025
Copy link
Member

@nieder nieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure:

sudo -u fink-bld [ENV] sh -c /tmp/fink.mT1hA
PYTHONPATH=. /sw/bin/python3.10 test_mccabe.py || exit 1
/sw/bin/python3.10: can't open file '/sw/build.build/pre-commit-py310-4.1.0-1/pre_commit-4.1.0/test_mccabe.py': [Errno 2] No such file or directory
### execution of PYTHONPATH=. failed, exit code 1

test_mccabe.py doesn't exist in the tarball.

  1. setup.cfg says it requires nodeenv, but it's not present in Depends or BuildDepends.
  2. Can you alphabetize the BuildDepends field, and make sure none of those should actually be Depends?

@sth0
Copy link
Contributor Author

sth0 commented Apr 1, 2025

Thanks for the comments.

Starting to implement requested changes. However going down a rabbit hole in creating package for nodeenv. It builds but does not pass tests. Does the error below indicate missing packages for the testing phase? Do I need to also create packages for helpconfig-py and pytest_cmdline_parse-py. Or should I submit nodeenv with the test phase commented out?
Please advise.

Successfully built nodeenv-1.9.1-py2.py3-none-any.whl
sudo -u fink-bld [ENV] sh -c /tmp/fink.omPpS
PYTHONPATH=/opt/sw/src/fink.build/nodeenv-py310-1.9.1-1/nodeenv-1.9.1/src /opt/sw/bin/python3.10 -m pytest -k -vv || exit 2
/opt/sw/lib/python3.10/site-packages/_pytest/config/__init__.py:331: PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown.
Plugin: helpconfig, Hook: pytest_cmdline_parse
UsageError: usage: __main__.py [options] [file_or_dir] [file_or_dir] [...]
__main__.py: error: argument -k: expected one argument
For more information see https://pluggy.readthedocs.io/en/stable/api_reference.html#pluggy.PluggyTeardownRaisedWarning
  config = pluginmanager.hook.pytest_cmdline_parse(
ERROR: usage: __main__.py [options] [file_or_dir] [file_or_dir] [...]
__main__.py: error: argument -k: expected one argument

### execution of PYTHONPATH=/opt/sw/src/fink.build/nodeenv-py310-1.9.1-1/nodeenv-1.9.1/src failed, exit code 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new package Packages that do not yet exist in Fink.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants