fix: Add Apache-2.0 license headers to source files (2) #1253
+2,953
−2,736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherry picking changes as requested for PR 1017
merging license header changes from PR 1017 as advised
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
coopernetes
reviewed
Oct 30, 2025
There was a problem hiding this comment.
Need to fix up the package.json changes.
Other than that, LGTM. We expect this to fail in CI for the first build after merging. Then, we can apply the fixes across all source files (will be a large PR). Note that it may impact other branches but given this is a large formatting change, it's unavoidable to integrate the new ESLint rule.
There was a problem hiding this comment.
@sam-holmes2 I believe these changes, other than the addition of eslint-plugin-license-header (L112), should be reverted or merged from main. Mind tidying this up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked branch from https://github.com/RBC/finos-git-proxy/tree/chore/eslint-license to hopefully avoid conflicts as requested.
Changes add ESLint rule with auto-fixable license headers added to source files (more info in original PR #1017)