Skip to content

Conversation

@IshwaryaSriram
Copy link

@IshwaryaSriram IshwaryaSriram commented Nov 15, 2024

This PR addresses #240 and adds unit test cases, ensuring at least 80% test coverage for src/service/routes/*

Note:

  1. No changes to existing code base logic (except for logger in src/service/routes/push.js); purely test additions.
  2. This is my first contribution and part of the Citi Hackathon.

Please review the PR and let me know if there are any updates or changes needed.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 15, 2024

CLA Not Signed

@netlify
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 7f87fd5
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/67b02eeee471b800084202ed

@coopernetes
Copy link
Contributor

Hi @IshwaryaSriram thank you for the contribution! Please remember to sign the CLA so this PR can be eventually merged.

@coopernetes
Copy link
Contributor

Hmm... Two of the tests are failing in CI. Can you review the logs and resolve the failures?

https://github.com/finos/git-proxy/actions/runs/13342403098/job/37268710992?pr=802

  56 passing (11s)
  2 failing

  1) clear bare and local clones
       pull remote generates a local .remote folder:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/git-proxy/git-proxy/test/testClearBareClone.test.js)
      at listOnTimeout (node:internal/timers:569:17)
      at process.processTimers (node:internal/timers:512:7)

  2) validate config files
       all invalid config files should fail validation:
     Uncaught Error: ENOTEMPTY: directory not empty, rmdir './.remote/1739599657030/git-proxy/.git/refs'

@06kellyjac 06kellyjac added the citi-hackathon Related to the Citi India Hackathon (Oct '24) label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation citi-hackathon Related to the Citi India Hackathon (Oct '24)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants