Skip to content

Update CoordinateMapping interface for normals/tangents #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update CoordinateMapping interface for normals/tangents #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc31cd0
Allow reference edge normal/tangents to be normalized or scaled in Co…
rckirby Aug 31, 2020
babe687
fix stupid bug
rckirby Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tsfc/fem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,14 +166,19 @@ def detJ_at(self, point):
context = PointSetContext(**config)
return map_expr_dag(context.translator, expr)

def reference_normals(self):
def reference_normals(self, normalized=True):
if not (isinstance(self.interface.fiat_cell, UFCSimplex) and
self.interface.fiat_cell.get_spatial_dimension() == 2):
raise NotImplementedError("Only works for triangles for now")
return gem.Literal(numpy.asarray([self.interface.fiat_cell.compute_normal(i) for i in range(3)]))
cn = (self.interface.fiat_cell.compute_normal if normalized
else self.interface.fiat_cell.compute_scaled_normal)
return gem.Literal(numpy.asarray([cn(i) for i in range(3)]))

def reference_edge_tangents(self):
return gem.Literal(numpy.asarray([self.interface.fiat_cell.compute_edge_tangent(i) for i in range(3)]))
def reference_edge_tangents(self, normalized=False):
ct = (self.interface.fiat_cell.compute_normalized_edge_tangent
if normalized else self.interface.fiat_cell.compute_edge_tangent)

return gem.Literal(numpy.asarray([ct(i) for i in range(3)]))

def physical_tangents(self):
if not (isinstance(self.interface.fiat_cell, UFCSimplex) and
Expand Down