Skip to content

revert using portal for render menu and add exenv package for checkin… #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

revert using portal for render menu and add exenv package for checkin… #167

wants to merge 1 commit into from

Conversation

nhuttm
Copy link

@nhuttm nhuttm commented Jan 15, 2021

I have found an issue related to position: fixed. If the parent of Menu has a CSS transform the Menu will fix with its parent.
This PR includes:

  • Revert drop portal commit for using react portal to render menu.
  • Add exenv package for checking available dom features

Error demo

@nhuttm nhuttm force-pushed the nhuttm/fix-wrong-position-of-menu branch from 5bf192c to 8e91f51 Compare January 15, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nhuttm