Skip to content

feat: Add isFocusable to ToastOptions #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add isFocusable to ToastOptions #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/Toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ export const Toast: React.FC<ToastProps> = props => {
isLoading,
closeOnClick,
theme,
ariaLabel
ariaLabel,
isFocusable
} = props;
const defaultClassName = cx(
`${Default.CSS_NAMESPACE}__toast`,
Expand Down Expand Up @@ -81,7 +82,7 @@ export const Toast: React.FC<ToastProps> = props => {
>
<div
id={toastId as string}
tabIndex={0}
tabIndex={isFocusable !== false ? 0 : -1}
onClick={onClick}
data-in={isIn}
className={cssClasses}
Expand Down
6 changes: 6 additions & 0 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,12 @@ export interface ToastOptions<Data = unknown> extends CommonOptions {
delay?: number;

isLoading?: boolean;

/**
* If true, the toast will be focusable.
* Default: true
*/
isFocusable?: boolean;
}

export interface UpdateOptions<T = unknown> extends Nullable<ToastOptions<T>> {
Expand Down