Skip to content

Conversation

juev
Copy link
Contributor

@juev juev commented Jun 6, 2025

Overview

Trying to use nelm as a replacement for helm

What this PR does / why we need it

These are improvements to the existing PR #594

ldmonster and others added 23 commits May 30, 2025 13:53
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Ilya Lesikov <[email protected]>
Signed-off-by: Ilya Lesikov <[email protected]>
Signed-off-by: Evsyukov Denis <[email protected]>
… from release annotations

Signed-off-by: Evsyukov Denis <[email protected]>
…e management and label handling

Signed-off-by: Evsyukov Denis <[email protected]>
… release management

- Introduced NelmActions interface for better abstraction of release operations.
- Refactored NelmClient to utilize the new interface for actions like ReleaseGet, ReleaseInstall, and others.
- Updated tests to accommodate the new structure and ensure functionality remains intact.

Signed-off-by: Evsyukov Denis <[email protected]>
…s purpose and behavior

Signed-off-by: Evsyukov Denis <[email protected]>
…d code organization

- Added missing import for utils in nelm_test.go.
- Changed map types from `map[string]interface{}` to `map[string]any` for better type safety.
- Removed unused test client creation functions in nelm_test.go.
- Improved release names handling in ListReleasesNames method in nelm.go.

Signed-off-by: Evsyukov Denis <[email protected]>
- Updated logging to include chart name when release name is empty, improving clarity in logs.

Signed-off-by: Evsyukov Denis <[email protected]>
…easesNames method

- Simplified ListReleasesNames by removing the check for empty release names, as it is no longer needed.

Signed-off-by: Evsyukov Denis <[email protected]>
- Replaced string concatenation with strings.Builder for improved performance in the Render method of NelmClient.

Signed-off-by: Evsyukov Denis <[email protected]>
- Updated NewNelmClient to eliminate the actions parameter, defaulting to DefaultNelmActions.
- Adjusted tests in nelm_test.go to set actions after client creation for consistency.

Signed-off-by: Evsyukov Denis <[email protected]>
- Changed nelmLog.Default to nelmLog.DefaultNull in NewNelmClient for improved logging behavior.

Signed-off-by: Evsyukov Denis <[email protected]>
- Updated InitHelmClientFactory to initialize Nelm client when USE_NELM environment variable is set.
- Enhanced tests to verify detection of Nelm client and its initialization.

Signed-off-by: Evsyukov Denis <[email protected]>
@juev juev self-assigned this Jun 6, 2025
@juev juev added enhancement New feature or request go Pull requests that update Go code labels Jun 6, 2025
…lOptions and improve error handling in GetReleaseChecksum

Signed-off-by: Evsyukov Denis <[email protected]>
@juev juev force-pushed the feature/nelm branch 2 times, most recently from 9862787 to 7157248 Compare June 11, 2025 09:41
ldmonster added 26 commits June 17, 2025 10:38
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
@ldmonster ldmonster closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants