Add wrapping settings for surface mesh generation (snappy integration) #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maciej-flexcompute
commented
Jul 8, 2025
maciej-flexcompute
commented
- Introduced new classes: MeshQuality, SnapControls, GeometrySettings, and WrappingSettings to manage mesh generation parameters.
- Updated MeshingParams to include wrapping_settings.
- Enhanced surface meshing translator to handle wrapping settings in JSON output.
- Added unit tests for wrapping settings functionality and validation against expected JSON output.
- Introduced new classes: MeshQuality, SnapControls, GeometrySettings, and WrappingSettings to manage mesh generation parameters. - Updated MeshingParams to include wrapping_settings. - Enhanced surface meshing translator to handle wrapping settings in JSON output. - Added unit tests for wrapping settings functionality and validation against expected JSON output.
- Updated GeometrySettings to use EntityList for storing entities. - Modified surface meshing translator to access stored entities correctly. - Simplified test cases by allowing wildcard entity selection in geometry settings.
…fluid type in WrappingSettings - Modified edge grouping logic to only apply when edge_ids are present, - Changed cad_is_fluid from bool to Optional in WrappingSettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.