-
Notifications
You must be signed in to change notification settings - Fork 1.8k
dockerfile: update to Debian Trixie #11006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Patrick Stephens <[email protected]>
WalkthroughSwaps Debian base images from bookworm to trixie across Dockerfile stages, updates APT backports references from bookworm-backports to trixie-backports, adjusts systemd-related package names accordingly, and updates the distroless production base from cc-debian12 to cc-debian13. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Patrick Stephens <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
dockerfiles/Dockerfile (2)
232-263
: Replace dnsutils with bind9-dnsutils in debug stage
dnsutils isn’t available on Debian trixie; bind9-dnsutils is. librtmp1 remains valid.
125-172
: Fix invalid package names and remove unnecessary runtime tools
apt-get download will fail on Trixie for these names:
• libssl3, libcurl4, libssh2-1, libpsl5, libgnutls30, libunistring2, libnettle8, libhogweed6, libldap-2.6-0
Verify and update each to the correct Debian package (e.g. via apt-cache) before commit.
librtmp1 exists on Trixie; only remove if your app doesn’t need it. Drop pkg-config from the distroless runtime.
🧹 Nitpick comments (2)
dockerfiles/Dockerfile (2)
38-52
: Backports enablement OK; prefer dedicated sources.list.d entry.
Current approach works; for hygiene, write backports to /etc/apt/sources.list.d/backports.list instead of appending to the main sources.list.-RUN echo "deb http://deb.debian.org/debian trixie-backports main" >> /etc/apt/sources.list && \ +RUN echo "deb http://deb.debian.org/debian trixie-backports main" > /etc/apt/sources.list.d/backports.list && \ apt-get update && \ apt-get install -y --no-install-recommends \ ...
180-180
: Consider pinning distroless base by digest.
Improves supply-chain integrity and reproducibility; you already ignore DL3006 in hadolint, but pinning is recommended.-FROM gcr.io/distroless/cc-debian13 AS production +# Example (replace with current digest): +# FROM gcr.io/distroless/cc-debian13@sha256:<digest> AS production +FROM gcr.io/distroless/cc-debian13 AS production
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
dockerfiles/Dockerfile
(10 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: PR - Docker windows build test, windows 2022 and 2025 (2025)
- GitHub Check: PR - Docker windows build test, windows 2022 and 2025 (2022)
- GitHub Check: PR - Classic docker build test
🔇 Additional comments (3)
dockerfiles/Dockerfile (3)
22-22
: Base image bump to trixie looks good.
No issues spotted with switching builder base to Debian 13.
117-117
: Extractor base image bump to trixie looks good.
No concerns with aligning extractor to Debian 13.
211-211
: Debug base image bump to trixie looks good.
No concerns with aligning debug image to Debian 13.
Distroless containers for Trixie/13 are now available to test: GoogleContainerTools/distroless#1851 (comment)
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit
Chores
Impact