-
Notifications
You must be signed in to change notification settings - Fork 1.8k
workflows: Handle 4.1 branches events and fix type inference errors for 4.0 branch #11062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: Handle 4.1 branches events and fix type inference errors for 4.0 branch #11062
Conversation
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
WalkthroughGitHub Actions workflow configuration files are updated: version reference '4.0' is wrapped in quotes for proper YAML string handling in staging-release.yaml, and branch 4.1 is added to push and pull_request trigger events in unit-tests.yaml. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/staging-release.yaml (1)
970-970: Inconsistent quoting of version references across the workflow.Lines 970 and 1074 now quote the version ref as
'4.0', but earlier version branches in similar contexts remain unquoted (e.g., line 1038:ref: 2.0). For consistency and robustness, either quote all numeric-looking version refs uniformly or clarify why only 4.0 requires quoting.- name: Release 2.0 if: startsWith(inputs.version, '2.0') uses: actions/checkout@v5 with: - ref: 2.0 + ref: '2.0'Also applies to: 1074-1074
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/staging-release.yaml(2 hunks).github/workflows/unit-tests.yaml(1 hunks)
🔇 Additional comments (1)
.github/workflows/unit-tests.yaml (1)
3-13: Branch 4.1 is missing from push triggers; only added to pull_request triggers.The PR adds branch 4.1 to pull_request triggers (line 25) but not to push triggers (lines 3-13). This creates an asymmetry where tests run on PRs targeting 4.1 but not on direct pushes to that branch. Given the PR objective to "handle 4.1 branches events," consider adding 4.1 (and 4.0 for consistency) to the push triggers as well.
on: push: branches: - master + - 4.1 + - 4.0 - 3.2 - 3.1 - 3.0 - 2.2 - 2.1 - 2.0 - 1.9 - 1.8Also applies to: 25-25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably need to update the nightly builds as well
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit