Skip to content

Conversation

@cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Oct 22, 2025


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Chores
    • Added branch 4.1 to automated testing triggers for push and pull request events.
    • Updated workflow configuration for consistent version reference handling.

@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2025

Walkthrough

GitHub Actions workflow configuration files are updated: version reference '4.0' is wrapped in quotes for proper YAML string handling in staging-release.yaml, and branch 4.1 is added to push and pull_request trigger events in unit-tests.yaml.

Changes

Cohort / File(s) Summary
GitHub Actions workflow configuration
​.github/workflows/staging-release.yaml, ​.github/workflows/unit-tests.yaml
staging-release.yaml: Wrapped version reference '4.0' in quotes for consistent YAML string handling; unit-tests.yaml: Added branch 4.1 to both push and pull_request trigger events

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • fluent/fluent-bit#10712: Modifies the same staging-release.yaml workflow for version-specific branch handling around 4.0/4.1 checkouts.
  • fluent/fluent-bit#10993: Restructures 4.x version release paths in the same staging-release.yaml workflow.

Suggested labels

backport to v4.0.x

Suggested reviewers

  • niedbalski
  • patrick-stephens
  • celalettin1286

Poem

A rabbit hops through workflows bright ✨
Quoting versions, getting it right
Branch 4.1 now joins the race
CI pipelines set their pace 🐰

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "workflows: Handle 4.1 branches events and fix type inference errors for 4.0 branch" directly and accurately describes both main changes in the changeset. The first part references adding branch 4.1 to the unit-tests workflow triggers for push and pull_request events, while the second part refers to fixing type inference in the staging-release workflow by wrapping the 4.0 version reference in quotes. The title is specific, clear, and concise without vague terminology or noise, making it easy for reviewers to understand the primary changes at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cosmo0920-handle-4.1-branches-events

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/staging-release.yaml (1)

970-970: Inconsistent quoting of version references across the workflow.

Lines 970 and 1074 now quote the version ref as '4.0', but earlier version branches in similar contexts remain unquoted (e.g., line 1038: ref: 2.0). For consistency and robustness, either quote all numeric-looking version refs uniformly or clarify why only 4.0 requires quoting.

  - name: Release 2.0
    if: startsWith(inputs.version, '2.0')
    uses: actions/checkout@v5
    with:
-     ref: 2.0
+     ref: '2.0'

Also applies to: 1074-1074

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65722e8 and a641841.

📒 Files selected for processing (2)
  • .github/workflows/staging-release.yaml (2 hunks)
  • .github/workflows/unit-tests.yaml (1 hunks)
🔇 Additional comments (1)
.github/workflows/unit-tests.yaml (1)

3-13: Branch 4.1 is missing from push triggers; only added to pull_request triggers.

The PR adds branch 4.1 to pull_request triggers (line 25) but not to push triggers (lines 3-13). This creates an asymmetry where tests run on PRs targeting 4.1 but not on direct pushes to that branch. Given the PR objective to "handle 4.1 branches events," consider adding 4.1 (and 4.0 for consistency) to the push triggers as well.

  on:
    push:
      branches:
        - master
+       - 4.1
+       - 4.0
        - 3.2
        - 3.1
        - 3.0
        - 2.2
        - 2.1
        - 2.0
        - 1.9
        - 1.8

Also applies to: 25-25

Copy link
Collaborator

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to update the nightly builds as well

@patrick-stephens patrick-stephens merged commit 6345fd1 into master Oct 22, 2025
16 checks passed
@patrick-stephens patrick-stephens deleted the cosmo0920-handle-4.1-branches-events branch October 22, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants