Skip to content

Conversation

pq
Copy link
Collaborator

@pq pq commented Sep 11, 2025

Add digit separator support to Color-parsing.

Fixes: #8510.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested review from jwren and helin24 September 11, 2025 22:54
@pq pq merged commit 03b4dc7 into flutter:main Sep 12, 2025
7 checks passed
@pq pq deleted the fix_colors_digitSeparators branch September 12, 2025 00:59
@helin24
Copy link
Member

helin24 commented Sep 12, 2025

@pq just curious, was this indeed a "good-first-issue"? I've often been guessing with that label. What made you pick up this issue?

@pq
Copy link
Collaborator Author

pq commented Sep 12, 2025

It would have been an easy first issue. I grabbed it because I was already looking at the color provider and was "in the neighborhood". That it was a quick fix was a bonus!

@helin24
Copy link
Member

helin24 commented Sep 12, 2025

Cool! Maybe that could be an AI workflow, i.e. "are there easy issues I can fix while I'm here"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color preview doesn't work with digit separators
2 participants