Skip to content

Conversation

amir14a
Copy link

@amir14a amir14a commented Aug 26, 2025

Adds missing error codes to error_codes.dart that were used during the development of version 1.6.0.

In version 1.6.0 of the local_auth package, two new error codes were added and used in the package's implementation; however, they were not added to the error_codes.dart file. Therefore, users cannot use them unless they are hardcoded.
This PR is added them to the error_codes.dart.
Relative links:

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link

google-cla bot commented Aug 26, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds two missing error codes, userCancelled and userFallback, to the local_auth package. These were already in use within the local_auth_darwin implementation, and this change makes them available to developers without hardcoding. My review includes a suggestion to improve the accuracy of the documentation for these new codes.

amir14a and others added 2 commits August 26, 2025 16:36
add macOS to the comment.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@amir14a amir14a force-pushed the add-missing-error-codes branch from 59f6099 to ddca20d Compare August 26, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant