-
-
Notifications
You must be signed in to change notification settings - Fork 26
chore: update rust edition to 2024 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Gurgel100 Disable layout tests in BindgenThe MSFS SDK headers use interfaces with virtual methods. You can't really perform meaningful layout tests when you're interacting with these types via opaque pointers instead of passing by value. #![allow(unsafe_op_in_unsafe_fn)]Adding unsafe blocks to the bodies of all the unsafe functions would involve adding more boilerplate to the build.rs file than is needed, for no additional safety benefit. The functions themselves are already marked as unsafe. |
Co-authored-by: Pascal Störzbach <[email protected]>
Co-authored-by: Pascal Störzbach <[email protected]>
Co-authored-by: Pascal Störzbach <[email protected]>
This change updates the crate to be compatible with the latest edition of rust (2024 as of creating this). without introducing any breaking API changes.
I have squashed some of the existing compiler errors but the vast majority seem to be stemming from a bindgen rust file that's generated at compile time.
Edit: I managed to get rid of the build errors by updating bindgen to the latest version