Update README #37
Open
Update README #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice work! I would add a section on how to compile and run the examples. |
|
@Eagle941 Thank you for looking at it, I updated the PR based on your feedback 🎉 I have no clue about building or running the other examples as they are targeting something very different from what I am trying to do. Another PR would have to improve on their build instructions in the future. |
tracernz
approved these changes
Aug 21, 2025
|
@tracernz Thank you, is it mergable then? |
Gurgel100
reviewed
Aug 27, 2025
README.md
Outdated
| background_color=0,0,255 | ||
| htmlgauge00=WasmInstrument/WasmInstrument.html?wasm_module=gauge_logic.wasm&wasm_gauge=Demo, 0,0,1024,768 | ||
| ``` | ||
| <img width="700" alt="grafik" src="https://github.com/user-attachments/assets/babe0670-51bf-4a33-8fc6-5e282667febe" /> |
There was a problem hiding this comment.
Can you check in this image as well?
Instead of hosting them on GitHub, based on feedback in PR flybywiresim#37
|
@Gurgel100 Thanks for the review, I added the image to the repo locally. The main FBW aircraft repo had the images as a link but this also works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the msfs-rs project more accessible to beginners, I created a README.