-
Notifications
You must be signed in to change notification settings - Fork 61
@W-16556387: [ReactNative][Android] Upgrade to React Native 0.79 #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…imal Updates To `package.json` And Changes From `yarn install`)
…prehensive Update To `package.json` Matching React Native Upgrade Helper Updates To SalesforceMobileSDK-Android And SalesforceMobileSDK-Templates)
package.json
Outdated
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/forcedotcom/SalesforceMobileSDK-ReactNative.git" | ||
"url": "https://github.com/JohnsonEricAtSalesforce/SalesforceMobileSDK-ReactNative.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To-Do: I'll flip this back before merge.
}, | ||
"peerDependencies": { | ||
"react-native": "0.74.7" | ||
"react-native": "0.79.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went over the upgrade notes in the Upgrade Helper with a fine-tooth comb plus also synchronized all the dependencies between the repositories.
…rect Imports In `SFNetReactBridge.m`)
…tore Repository References In `package.json`)
#import <SalesforceSDKCore/NSDictionary+SFAdditions.h> | ||
#import <SalesforceSDKCore/NSURLResponse+SFAdditions.h> | ||
#import <SalesforceSDKCore/SFRestAPI+Blocks.h> | ||
@import SalesforceSDKCore; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ate iosTests package.json)
83e5aa7
to
41fe54d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #413 +/- ##
======================================
Coverage ? 76.12%
======================================
Files ? 13
Lines ? 557
Branches ? 0
======================================
Hits ? 424
Misses ? 133
Partials ? 0 🚀 New features to boost your workflow:
|
🥁 Ready For Review! 🎸
This updates to React Native 0.79.3 according to the Upgrade Helper at https://react-native-community.github.io/upgrade-helper/
Note this has been testing in SalesforceMobileSDK-Android, iOS and both platform templates as well. The tests pass to match current
dev
in each repo.