-
Notifications
You must be signed in to change notification settings - Fork 3.8k
SMBServer & NTLMRelayx with IPv6 support #2024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lnking with #1811 |
On 5c176fa didn't call same function |
Added a comment explaining why repeated code in SMBSERVER constructor
it seems passing -6 parameter without --interface-ip, got broken:
|
It was failing every time we configured it to use IPv6 Thanks! |
anadrianmanrique
requested changes
Sep 19, 2025
anadrianmanrique
approved these changes
Sep 20, 2025
merging now, Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1787
-6
(or--ipv6
) flag parameterIt also fixes IPv6 support in
ntlmrelayx
-6
was set and a specific-ip
was configuredNote: It has to be updated after merging #2023 to reuse the
utils.get_address
function.