httpRelayServer: restore POST body handling and add HTTPS/TLS support #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes two improvements to httprelayserver.py: 1. Restore POST body draining logic (fortra#913): - Re-applies fix originally merged in 2021 by Rcarnus. - Ensures POST request bodies are consumed before returning 401 Unauthorized. - Fixes WSUS and other web clients that retry authentication on the same TCP stream. 2. Add HTTPS/TLS support with improved logging: - Introduce optional SSL context when --https, --certfile, and --keyfile are provided. - Wrap inbound sockets with TLS, logging negotiated protocol/cipher on success. - On failures, log SSL error details, flagging early EOFs (likely client cert rejection). - Add startup banner showing port, IPv6/HTTPS status for clarity. Together these changes allow ntlmrelayx to: - Correctly handle WSUS POST-based authentication flows. - Relay over HTTPS endpoints (e.g., WSUS 8531) with real certs or self-signed. - Provide more useful debug information for operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpRelayServer: restore POST body handling and add HTTPS/TLS support
This commit makes two improvements to httprelayserver.py:
Restore POST body draining logic (httpRelayServer: read body content for POST requests #913):
Add HTTPS/TLS support with improved logging:
Together these changes allow ntlmrelayx to: