Skip to content

[WMI] Fix confusion between propertyType and cimType #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

[WMI] Fix confusion between propertyType and cimType #2035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions impacket/dcerpc/v5/dcom/wmi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class ENCODED_VALUE(Structure):
def getValue(cls, cimType, entry, heap):
# Let's get the default Values
pType = cimType & (~(CIM_ARRAY_FLAG|Inherited))

cimType = cimType & (~Inherited)
if entry != 0xffffffff:
heapData = heap[entry:]
if cimType & CIM_ARRAY_FLAG:
Expand Down Expand Up @@ -926,9 +926,10 @@ def printClass(self, pClass, cInstance = None):
print('\t[%s(%s)]' % (qName, qualifiers[qName]))
print("\t%s %s" % (properties[pName]['stype'], properties[pName]['name']), end=' ')
if properties[pName]['value'] is not None:
if properties[pName]['type'] == CIM_TYPE_ENUM.CIM_TYPE_OBJECT.value:
cimType = properties[pName]['type'] & (~Inherited)
if cimType == CIM_TYPE_ENUM.CIM_TYPE_OBJECT.value:
print('= IWbemClassObject\n')
elif properties[pName]['type'] == CIM_TYPE_ENUM.CIM_ARRAY_OBJECT.value:
elif cimType == CIM_TYPE_ENUM.CIM_ARRAY_OBJECT.value:
if properties[pName]['value'] == 0:
print('= %s\n' % properties[pName]['value'])
else:
Expand Down Expand Up @@ -2613,7 +2614,8 @@ def SpawnInstance(self):
def createProperties(self, properties):
for property in properties:
# Do we have an object property?
if properties[property]['type'] == CIM_TYPE_ENUM.CIM_TYPE_OBJECT.value and properties[property]['value'] != None:
cimType = properties[property]['type'] & (~Inherited)
if cimType == CIM_TYPE_ENUM.CIM_TYPE_OBJECT.value and properties[property]['value'] != None:
# Yes.. let's create an Object for it too
objRef = OBJREF_CUSTOM()
objRef['iid'] = self._iid
Expand All @@ -2623,7 +2625,7 @@ def createProperties(self, properties):
objRef['pObjectData'] = properties[property]['value']
value = IWbemClassObject( INTERFACE(self.get_cinstance(), objRef.getData(), self.get_ipidRemUnknown(),
oxid=self.get_oxid(), target=self.get_target()))
elif properties[property]['type'] == CIM_TYPE_ENUM.CIM_ARRAY_OBJECT.value:
elif cimType == CIM_TYPE_ENUM.CIM_ARRAY_OBJECT.value:
if isinstance(properties[property]['value'], list):
value = list()
for item in properties[property]['value']:
Expand Down