Fix output when printing table rows #2037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each time a row is printed in the
printRows
function intds.py
a new line as added using the\n
character. However, due to the way theDummyPrint
class handles the\n
character, two new lines are added leading to an additional (unnecessary) new line:impacket/impacket/tds.py
Lines 57 to 64 in 082dca3
Example screenshot from the current state:
This is fixed by using the character

\r
, which is interpreted as a single new line by theDummyPrint
class, resulting in proper table formatting: