Skip to content

[lib/test.js] Support URLs without leading slash #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[lib/test.js] Support URLs without leading slash #512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f78144
[lib/test.js] Support URLs without leading slash
petermikitsh Sep 14, 2018
50107d3
fix syntax error
petermikitsh Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ var util = require('util');
var http = require('http');
var https = require('https');
var assert = require('assert');
var url = require('url');
var Request = request.Request;

/**
Expand Down Expand Up @@ -59,7 +60,7 @@ Test.prototype.serverAddress = function(app, path, host) {
if (!addr) this._server = app.listen(0);
port = app.address().port;
protocol = app instanceof https.Server ? 'https' : 'http';
return protocol + '://' + (host || '127.0.0.1') + ':' + port + path;
return url.resolve(protocol + '://' + (host || '127.0.0.1') + ':' + port, path);
};

/**
Expand Down