Skip to content

Gardening code with hlint #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Gardening code with hlint #88

wants to merge 9 commits into from

Conversation

cblp
Copy link

@cblp cblp commented Apr 11, 2019 •
edited
Loading

This change is Reviewable

bitonic
bitonic requested changes Apr 29, 2019
View reviewed changes
Copy link
Collaborator

@bitonic bitonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please do not forbid do blocks with a single statement -- i like to preemptively put dos to minimize diff noise
  • please add hlint to CI.

@cblp
Copy link
Author

cblp commented May 6, 2019

i like to preemptively put dos to minimize diff noise

it makes sense in tests, but... everywhere?

@cblp
Copy link
Author

cblp commented May 6, 2019

Restored do's in tests.

@cblp
Copy link
Author

cblp commented May 6, 2019

Integrated to Travis.

@bitonic
Copy link
Collaborator

bitonic commented Jun 18, 2019

it makes sense in tests, but... everywhere?

Yes, everywhere -- it makes editing and diffing a lot more pleasant.

@junjihashimoto junjihashimoto force-pushed the master branch 2 times, most recently from 01bd932 to ef87fba Compare September 29, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitonic bitonic bitonic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cblp @bitonic