Update to add timezone support. #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid timezone support warnings, change default values for
metric items and gauges to timezone aware equivalents from
django.utils.timezone.
This requires some changes to move_to_mixpanel command so timestamps can
be calculated correctly. To support more platforms, changed the use of
strftime('%s') to a more compatible implementation that closely follows
the Python 3 implementation of timestamp().
Added timedelta_total_seconds() to allow continued support for Python
2.6.
Added tests for timestamp utility functions.
|
Seems to be breaking support for Django 1.3, where timezone doesn't exist. |
This was referenced Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid timezone support warnings, change default values for
metric items and gauges to timezone aware equivalents from
django.utils.timezone.
This requires some changes to move_to_mixpanel command so timestamps can
be calculated correctly. To support more platforms, changed the use of
strftime('%s') to a more compatible implementation that closely follows
the Python 3 implementation of timestamp().
Added timedelta_total_seconds() to allow continued support for Python
2.6.
Added tests for timestamp utility functions.