Skip to content

Fix critical buffer overflow vulnerability in HTTP request parsing #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix critical buffer overflow vulnerability in HTTP request parsing #757

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d103258
Fix critical buffer overflow vulnerability in HTTP request parsing
jack-kerouac Sep 17, 2025
abb41b4
Revert "Fix critical buffer overflow vulnerability in HTTP request pa…
jack-kerouac Oct 22, 2025
2fe401a
fix critical buffer overflow in HTTP request parsing
jack-kerouac Oct 22, 2025
07c9ba7
remove unnecessary post-increment when null-terminating buffer
jack-kerouac Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions BSB_LAN/BSB_LAN.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4514,7 +4514,7 @@ void loop() {
byte tx_msg[33] = { 0 }; // xmit buffer
char c = '\0';
const byte MaxArrayElement=252;
char cLineBuffer[MaxArrayElement]; //
char cLineBuffer[MaxArrayElement+1]; //
byte bPlaceInBuffer; // index into buffer
uint16_t log_now = 0;

Expand Down Expand Up @@ -4701,7 +4701,7 @@ void loop() {
}
}
}
cLineBuffer[bPlaceInBuffer++]=0;
cLineBuffer[bPlaceInBuffer]=0;
// if no credentials found in HTTP header, send 401 Authorization Required
if (USER_PASS[0] && !(httpflags & HTTP_AUTH) && isSerial == false) {
printHTTPheader(HTTP_AUTH_REQUIRED, MIME_TYPE_TEXT_HTML, HTTP_ADD_CHARSET_TO_HEADER, HTTP_FILE_NOT_GZIPPED, HTTP_NO_DOWNLOAD, HTTP_DO_NOT_CACHE);
Expand Down