-
-
Notifications
You must be signed in to change notification settings - Fork 15
feat: fetch proxy #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: fetch proxy #411
Conversation
The client should not need to know about how fetch is handled - that's the responsibility of the runner.
3d17952
to
4678141
Compare
Is this just useful for spying on the stuff? |
Mostly it's so we can fix this: freeCodeCamp/freeCodeCamp#60874 |
Last question: Do we want to default to replacing |
That's a good question... and one I should have thought about. I'm leaning towards replacing fetch by default just because it's less work on both sides. Partly because it's straightforward, partly because I can't think of a reason not to (other than the unimplemented functionality), but mostly because it's reversible. Nothing gets locked in if we choose the path of least resistance. What do you reckon? |
Good point. If it works, worst case scenario is eventually creating a challenge (test) that needs a change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending merge conflict 👍
Checklist:
Update index.md
)It's a bare-bones implementation, but it should support the functions we currently use and let devs know when they try to use something that's yet to be implemented